Page 2 of 3

Re: Is this product dead?

PostPosted: Sat Feb 28, 2015 11:52 pm
by asd
Hi Dimitar,

I did a little rework into the DSLogic gui, in order to implement session export. Now is possible to export the session into .srzip format which can be loaded again in pulseview or sigrok-cli. It is a workaround until somebody implements a sigrok driver. Take a look at https://github.com/asanza/DSLogic.git

Cheers.

Re: Is this product dead?

PostPosted: Wed Mar 04, 2015 8:35 pm
by dpenev
Hi Asd,

Oh good will take a look!

Do you think implementation of .srzip import back in dslogic GUI is feasible?
Do you build dslogic in Linux or Windows?

Thanks
Dimitar

Re: Is this product dead?

PostPosted: Fri Mar 06, 2015 3:39 am
by asd
Hi Dimitar,

I build it in Linux (Ubuntu 14.04.2 LTS). As for the feasibility of back-importing srzip, I dont really know. I also don't really think it will be usefull, as I can always do the capture in dslogic and the analysis with pulseview (or sigrok-cli).

Furthermore, I am actually triying to integrate dslogic into sigrok ( although is not going anywhere, well at least capture work, but I dont have any idea how to implement the triggers :S ), so I dont have time to try the srzip thing.

Cheers ;)

Re: Is this product dead?

PostPosted: Fri Mar 06, 2015 2:19 pm
by Anders
asd wrote:Furthermore, I am actually triying to integrate dslogic into sigrok ( although is not going anywhere, well at least capture work, but I dont have any idea how to implement the triggers :S ), so I dont have time to try the srzip thing.

I've started to play around with integrating dslogic myself into libsigrok, though due to extremely little time available, I've not gotten that far.

Would you consider pushing your work to a public repo? If I get some time to continue this, I could look at your work and not duplicate it myself. I'd assume that you plan to upstream it once you've something that works reasonable?

Re: Is this product dead?

PostPosted: Fri Mar 06, 2015 4:58 pm
by dpenev
Hi Anders,

Asd already has posted his repo https://github.com/asanza/DSLogic.git few messages above.

Dimitar

Re: Is this product dead?

PostPosted: Fri Mar 06, 2015 6:32 pm
by Anders
dpenev wrote:Asd already has posted his repo https://github.com/asanza/DSLogic.git few messages above.
Dimitar

Ah, I had just assumed that it was his work to export sessions there.

I was hoping for a "clean" libsigrok repo, where he was working on the sigrok integration. That would make it a lot easier to get teh dslogic support upstream... (As the libsigrok4dslogic part of the DSLogic.git is a total disaster, removing and changing unrelated files etc).

Re: Is this product dead?

PostPosted: Sat Mar 07, 2015 3:36 am
by asd
Anders wrote:Ah, I had just assumed that it was his work to export sessions there.

I was hoping for a "clean" libsigrok repo, where he was working on the sigrok integration. That would make it a lot easier to get teh dslogic support upstream... (As the libsigrok4dslogic part of the DSLogic.git is a total disaster, removing and changing unrelated files etc).


Yea, you are right, that was just the srzip export.

I got a clean repo with sigrok and the port of dslogic (but as I say, only capture work). I am triying to integrate the triggers, and if you are willing to help, you are welcome. The repository address is: https://github.com/asanza/libsigrok_dslogic.git.

If you have problems building it, let me know.

Cheers,

Re: Is this product dead?

PostPosted: Sat Mar 07, 2015 4:41 am
by Anders
Thanks for the link! Great work sofar!

That's a littile bit further than I had got myself sofar, so I'll take a closer look at your repo. (My main problem is a complete lack of time...)

Building it was no issue, I had built the current HEAD of upstream libsigrok a couple of days ago.

LIke I said, I'll take a thorough look at your repo, especially at the trigger integration. (Though, I can't promise when I'll have the time).

I assume that you plan to upstream your work when you've completed a few more steps?[list=][/list]

Re: Is this product dead?

PostPosted: Sat Mar 07, 2015 4:49 am
by asd
Anders wrote:I assume that you plan to upstream your work when you've completed a few more steps?[list=][/list]


Of course, if they accept it ;)

Just a thing, in the code there is a char constant "const char* config_path = "/path/to/fw/files" should be pointed to the path where the firmware files for dslogic are installed (the .fw and .bin).

Re: Is this product dead?

PostPosted: Sun Mar 08, 2015 4:05 am
by Anders
asd wrote:Of course, if they accept it ;)


Well, of course it might require a few roundtrips during the patch review; but apart from that, there's no reason not to accept it. (Maybe with some additional refactoring etc).

asd wrote:Just a thing, in the code there is a char constant "const char* config_path = "/path/to/fw/files" should be pointed to the path where the firmware files for dslogic are installed (the .fw and .bin).


I've found that and locally patch it to use the standard FIRMWARE_DIR macro. (And prepended the FW-names with "/".

Now I''m just about to find out why I'm getting a segfault after loading the driver etc. (Well, it's the hwdriver that segfault after sr_config_get().

edit.
(I've pushed that fix, and a couple of other minor patches to my github fork: https://github.com/darander/libsigrok_dslogic.git )